IBX-11776: Fixed invalidating files when the content version didn't change#80
Open
Sztig wants to merge 4 commits into
Open
IBX-11776: Fixed invalidating files when the content version didn't change#80Sztig wants to merge 4 commits into
Sztig wants to merge 4 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
…ted but the content version has not changed
Sztig
force-pushed
the
IBX-11776-sameversion-file-cache-purge-fix
branch
from
6eb6655 to
4960e6e
Compare
Contributor
|
For browser tests to pass you most likely need to backport the following: https://github.com/ibexa/http-cache/pull/78/changes#diff-6f36e7155819d94620ee9ed91d27e6b0c5f9cc9ff1332031dd6263eb9e51d677. |
konradoboza
reviewed
May 18, 2026
konradoboza
reviewed
May 18, 2026
|
konradoboza
approved these changes
May 18, 2026
alongosz
reviewed
Jun 2, 2026
| $purged = []; | ||
|
|
||
| foreach ($content->getFields() as $field) { | ||
| $value = $field->value; |
Member
There was a problem hiding this comment.
Please don't use magic where possible.
Suggested change
| $value = $field->value; | |
| $value = $field->getValue(); |
Comment on lines
+63
to
+77
| public function testNoFieldsDoesNotCallPurge(): void | ||
| { | ||
| $this->proxyClient->expects(self::never())->method('purge'); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([])); | ||
| } | ||
|
|
||
| public function testNonBinaryFieldIsSkipped(): void | ||
| { | ||
| $this->proxyClient->expects(self::never())->method('purge'); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([ | ||
| new Field(['value' => new \stdClass()]), | ||
| ])); | ||
| } |
Member
There was a problem hiding this comment.
These can be one test with a data provider
Comment on lines
+109
to
+131
| public function testImageValueWithNullUriIsSkipped(): void | ||
| { | ||
| $imageValue = new ImageValue(); | ||
| $imageValue->uri = null; | ||
|
|
||
| $this->proxyClient->expects(self::never())->method('purge'); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([ | ||
| new Field(['value' => $imageValue]), | ||
| ])); | ||
| } | ||
|
|
||
| public function testImageValueWithEmptyUriIsSkipped(): void | ||
| { | ||
| $imageValue = new ImageValue(); | ||
| $imageValue->uri = ''; | ||
|
|
||
| $this->proxyClient->expects(self::never())->method('purge'); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([ | ||
| new Field(['value' => $imageValue]), | ||
| ])); | ||
| } |
Member
There was a problem hiding this comment.
Seems these could also be attached to the mentioned data provider.
Comment on lines
+79
to
+107
| public function testImageValueWithUriIsInvalidated(): void | ||
| { | ||
| $imageValue = new ImageValue(); | ||
| $imageValue->uri = '/var/site/storage/images/foo.jpg'; | ||
|
|
||
| $this->proxyClient | ||
| ->expects(self::once()) | ||
| ->method('purge') | ||
| ->with('/var/site/storage/images/foo.jpg', []); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([ | ||
| new Field(['value' => $imageValue]), | ||
| ])); | ||
| } | ||
|
|
||
| public function testBinaryFileValueWithUriIsInvalidated(): void | ||
| { | ||
| $binaryValue = new BinaryFileValue(); | ||
| $binaryValue->uri = '/var/site/storage/original/application/foo.pdf'; | ||
|
|
||
| $this->proxyClient | ||
| ->expects(self::once()) | ||
| ->method('purge') | ||
| ->with('/var/site/storage/original/application/foo.pdf', []); | ||
|
|
||
| $this->subscriber->onPublishVersion($this->buildEvent([ | ||
| new Field(['value' => $binaryValue]), | ||
| ])); | ||
| } |
Member
There was a problem hiding this comment.
These are also candidates for another data provider + test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This bug happens when we have a draft and we are making changes in this draft (in our case - the image).
Since the files are served without tagging by default, regular tag invalidation that happens when publishing content is not enough to refresh the changes.
In our logic, since it is still a draft, the content version didn't change ergo the file is presented when published without any changes. Without this fix to see the changes we would need to republish the content once again.
I have added a subscriber
BinaryFileHttpCachePurgeSubscriberthat explicitly purges the URI for ezimage, ezbinaryfile, and ezmedia when publishing the content.