Skip to content

Fix code samples CI #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriendupuis merged 4 commits into from
Jun 1, 2026
Merged

Fix code samples CI #3237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
057f3f3
code_samples.yaml: Ignore more SA
adriendupuis Jun 1, 2026
06c34f6
code_samples.yaml: Ignore baseline issues
adriendupuis Jun 1, 2026
9a4ab8b
Revert "code_samples.yaml: Ignore baseline issues"
adriendupuis Jun 1, 2026
16cf740
phpstan-baseline.neon: adapt ignored patterns to PHP 7.4
adriendupuis Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/code_samples.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,30 @@ jobs:
composer config audit.ignore --json '{
"GHSA-68jq-c3rv-pcrr": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"GHSA-fc86-6rv6-2jpm": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"GHSA-r7cg-qjjm-xhqq": "As this is for code quality tests and not to run a production DXP, this can be ignored."
"GHSA-r7cg-qjjm-xhqq": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-5k7f-wvjj-jrgw": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-sjvz-tbbr-vwth": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-h8hf-ytnd-5t9q": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-wwb1-81rc-pd65": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-hgmw-wn4d-hpcy": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-kvv6-36cr-fkzb": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-n14z-jjjg-g8vd": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-3mcc-k66d-pydb": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-gw7n-z4yx-7xjt": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-dpx1-78wg-1kqs": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-21g2-dzjv-sky5": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-yhcn-xrg3-68b1": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-2wrf-1xmk-1pky": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-6319-ffpf-gx66": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-n7sg-8f52-pqtf": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-8kk8-h2xr-h5nx": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-2rbx-bjdx-4d4d": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-fs5b-x5k4-1h39": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-fbvq-z33h-r2np": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-g9zw-qxh8-pq8w": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-yd6k-t2gh-1m43": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-1tmc-rt7x-12w6": "As this is for code quality tests and not to run a production DXP, this can be ignored.",
"PKSA-xx6c-6d96-db2w": "As this is for code quality tests and not to run a production DXP, this can be ignored."
}'

- uses: ramsey/composer-install@v3
Expand Down
10 changes: 5 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ parameters:
path: code_samples/api/public_php_api/src/Controller/CustomFilterController.php

-
message: '#^Parameter \#1 \$string of function base64_encode expects string, string\|false given\.$#'
message: '#^Parameter \#1 \$str(ing)? of function base64_encode expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: code_samples/api/rest_api/create_image.json.php
Expand Down Expand Up @@ -151,7 +151,7 @@ parameters:
path: code_samples/api/rest_api/create_image.xml.php

-
message: '#^Parameter \#1 \$string of function base64_encode expects string, string\|false given\.$#'
message: '#^Parameter \#1 \$str(ing)? of function base64_encode expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: code_samples/api/rest_api/create_image.xml.php
Expand Down Expand Up @@ -181,13 +181,13 @@ parameters:
path: code_samples/api/rest_api/src/Rest/ValueObjectVisitor/RestLocation.php

-
message: '#^Parameter \#1 \.\.\.\$arrays of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
message: '#^Parameter \#1 (\.\.\.\$arrays|\$arr1) of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
identifier: argument.type
count: 1
path: code_samples/api/rest_api/src/Rest/ValueObjectVisitor/RestLocation.php

-
message: '#^Parameter \#2 \.\.\.\$arrays of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
message: '#^Parameter \#2 \.\.\.\$ar(rays|gs) of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
identifier: argument.type
count: 1
path: code_samples/api/rest_api/src/Rest/ValueObjectVisitor/RestLocation.php
Expand Down Expand Up @@ -283,7 +283,7 @@ parameters:
path: code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php

-
message: '#^Parameter \#2 \$string of function explode expects string, string\|null given\.$#'
message: '#^Parameter \#2 \$str(ing)? of function explode expects string, string\|null given\.$#'
identifier: argument.type
count: 1
path: code_samples/back_office/search/src/EventSubscriber/MySuggestionEventSubscriber.php
Expand Down
Loading