Skip to content

IBX-10854: Added ability to hide content item drafts#667

Open
vidarl wants to merge 2 commits into
4.6from
IBX-10854_Not_possible_to_hide_content_draft
Open

IBX-10854: Added ability to hide content item drafts#667
vidarl wants to merge 2 commits into
4.6from
IBX-10854_Not_possible_to_hide_content_draft

Conversation

@vidarl
Copy link
Copy Markdown
Contributor

@vidarl vidarl commented Oct 24, 2025 •
edited by alongosz
Loading

🎫 Issue IBX-10854

It is not possible to publish content in hidden state

For QA:

Note

Edited by @alongosz

Requires security testing, e.g., if user who doesn't have hide/reveal permissions is now able to do it.

Documentation:

@vidarl vidarl changed the base branch from main to 4.6 October 24, 2025 12:22
Steveb-p
Steveb-p reviewed Oct 24, 2025
View reviewed changes
Comment thread src/lib/Repository/ContentService.php Outdated
alongosz
alongosz reviewed Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR this is by-design. There's no purpose to hiding content drafts because content drafts can be read by people with versionread policy, the same as hidden content can be accessed. Are you trying to fix some fatal error or enable hiding drafts? TL;DR;.

@vidarl
Copy link
Copy Markdown
Contributor Author

vidarl commented Oct 27, 2025 •
edited
Loading

There's no purpose to hiding content drafts because

yes, it is. If you don't want content to be visible at time of publishing.

Are you trying to fix some fatal error or enable hiding drafts?

@alongosz
I am trying to publish content as hidden. The use-case is:
Write a new article but translate it to multiple languages before making it visible. Since admin-ui cannot edit multiple languages for the same version, publish it as hidden would do the trick

edited....

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 27, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vidarl vidarl requested review from Steveb-p and alongosz October 29, 2025 07:32
@vidarl
Copy link
Copy Markdown
Contributor Author

vidarl commented Nov 18, 2025

ping @alongosz @Steveb-p : I have answered on your comments. Please have a look again

Steveb-p
Steveb-p reviewed Nov 18, 2025
View reviewed changes
Comment thread src/lib/Repository/ContentService.php
Copy link
Copy Markdown
Contributor

@Steveb-p Steveb-p Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean, with this change, that for drafts every user has ability to hide & reveal?

Because we won't be checking permission resolver for drafts.

Copy link
Copy Markdown
Contributor Author

@vidarl vidarl Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed in ca2b306.
Unsure if it 100% safe to have $targets=[] in parameter to canUser() though, but seems to work fine for me when I test with limitation on content/hide policy

@Steveb-p

Copy link
Copy Markdown
Contributor Author

@vidarl vidarl May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation of what happens when $targets=[] is addressed in #667 (comment)

@Steveb-p

@konradoboza
Copy link
Copy Markdown
Contributor

konradoboza commented Dec 16, 2025

@vidarl please make sure #667 (comment) is addressed, PR is rebased and the CI lits green.

@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch from acbb2d8 to ca2b306 Compare February 10, 2026 11:37
@vidarl
Copy link
Copy Markdown
Contributor Author

vidarl commented Feb 24, 2026

@vidarl please make sure #667 (comment) is addressed, PR is rebased and the CI lits green.

@konradoboza
Done. Only sonar complains now about duplicated code in Tests. Which should be considered as a false-positive

konradoboza
konradoboza reviewed Feb 25, 2026
View reviewed changes
Comment thread src/lib/Repository/ContentService.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch from e6a3f58 to 6671254 Compare March 6, 2026 12:42
@vidarl vidarl requested a review from konradoboza March 9, 2026 14:59
konradoboza
konradoboza reviewed Mar 9, 2026
View reviewed changes
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php
@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch 2 times, most recently from 91fd72c to af81e00 Compare March 11, 2026 10:40
@vidarl vidarl requested a review from konradoboza March 11, 2026 11:33
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vidarl
Copy link
Copy Markdown
Contributor Author

vidarl commented Mar 24, 2026

@alongosz, @konradoboza, @Steveb-p : Can you have a new look on this one. I think all review comments has been addressed

Steveb-p
Steveb-p reviewed Mar 24, 2026
View reviewed changes
Comment thread src/lib/Repository/ContentService.php Outdated
konradoboza
konradoboza approved these changes Mar 24, 2026
View reviewed changes
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
@alongosz alongosz changed the title IBX-10854 not possible to hide content draft IBX-10854: Added ability to hide content item drafts Mar 24, 2026
alongosz
alongosz reviewed Mar 24, 2026
View reviewed changes
Comment thread src/lib/Repository/ContentService.php Outdated
@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch from 3e36e6e to ca88c8c Compare April 20, 2026 14:51
@vidarl vidarl requested a review from alongosz April 21, 2026 11:12
alongosz
alongosz reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another round of review:

Comment thread src/lib/Repository/ContentService.php Outdated
Comment thread src/lib/Repository/ContentService.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php Outdated
Comment thread tests/integration/Core/Repository/ContentServiceTest.php
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch from a8709d3 to c2ea69b Compare May 22, 2026 08:06
@vidarl vidarl force-pushed the IBX-10854_Not_possible_to_hide_content_draft branch from c2ea69b to 80a7dc1 Compare June 2, 2026 13:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels

Ready for QA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vidarl @konradoboza @Steveb-p @alongosz @mikadamczyk @tischsoic