IBX-11853: Updated bundle-generator skeletons for 6.0 bundles - #45
Draft
alongosz wants to merge 4 commits into
Draft
IBX-11853: Updated bundle-generator skeletons for 6.0 bundles#45alongosz wants to merge 4 commits into
alongosz wants to merge 4 commits into
Conversation
Bumped all ibexa/* constraints and the dev-main branch alias from 5.0 to 6.0, and PHPUnit from ^9.5 to ^12.5, in line with current 6.0 bundles (e.g. ibexa/connector-ai-assistant). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Dropped attributes and elements removed in PHPUnit 10+ (convert* attributes, verbose, beStrictAboutTodoAnnotatedTests, listeners), switched the DAMA extension to the bootstrap element, and added a cache directory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Without pipefail the job result reflected the cs2pr exit code, so a failing check-cs run piped into a succeeding cs2pr passed the job. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replaced the Console Application::add() call with addCommand(), as add() was removed in Symfony 8. Symfony 8 requires PHP 8.4, so the PHP requirement was raised accordingly and PHP 8.3 dropped from the CI matrix. Generated bundles are unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates the bundle skeletons and the generator application itself as part of the 6.0 revamp:
ibexa/*constraints and thedev-mainbranch alias bumped from 5.0 to 6.0, PHPUnit bumped from^9.5to^12.5, in line with current 6.0 bundles (e.g.ibexa/connector-ai-assistant).convert*/verbose/beStrictAboutTodoAnnotatedTestsattributes and<listeners>, switched the DAMA extension to<bootstrap>, added a cache directory).pipefailfix for code style CI jobs (skeletons and this repository): without it, the job result reflected thecs2prexit code, so a failingcheck-cspiped into a succeedingcs2prpassed the job.Application::add()(removed in Symfony 8) replaced withaddCommand(). Symfony 8 requires PHP 8.4, so the application's PHP requirement was raised and PHP 8.3 dropped from this repository's CI matrix. Generated bundles are unaffected (their skeletons still target PHP >= 8.3).For QA:
Generate a bundle with each skeleton and verify the output, e.g.:
The generated
composer.jsonshould reference~6.0.x-devpackages and PHPUnit 12, with no__PLACEHOLDER__leftovers. Requires PHP >= 8.4.