Publish scripts/sync-metrics.sh — the public tree referenced a file it did not ship - #84
Draft
ib823 wants to merge 1 commit into
Draft
Publish scripts/sync-metrics.sh — the public tree referenced a file it did not ship#84ib823 wants to merge 1 commit into
scripts/sync-metrics.sh — the public tree referenced a file it did not ship#84ib823 wants to merge 1 commit into
Conversation
…renced a file it did not ship `sync-metrics.sh` was excluded from the public branch under "internal sync/verification scripts (not needed by external users)". That rationale did not hold for this one: TWELVE published files reference it, so the public tree shipped tooling that pointed at a file that was not there. Not only prose. `00_SETUP/hooks/pre-commit` INVOKES it, so a public clone's pre-commit hook called a missing script; and `riinac/tests/metrics_doc_consistency.rs` fails with "run `bash scripts/sync-metrics.sh` and stage the result" — advice a public clone could not follow. The other references are .cursorrules, copilot-instructions, MAINTAINER_ONBOARDING, AGENTS.md, COPILOT.md, llms.txt, DOMAIN_R5_CHECKLIST, audit-docs.sh and generate-metrics.sh. FOUND while back-merging riina #15, which adds a mirror-local `scripts/mirror-propagate-metrics.sh`. That commit exists precisely because the mirror lacks this script, and says the last three metrics refreshes propagated the count into the docs BY HAND as a result. The workaround was the symptom; the exclusion was the cause. SAFE TO PUBLISH, verified rather than assumed: - no secrets, tokens or container-absolute paths (grepped) - no gate depends on its exclusion (verify-public.sh, public-quality-gates.sh) - it guards every target with `if [ -f ]`, so the internal-only files it also knows about (CLAUDE.md, PROGRESS.md) are skipped on a tree that lacks them Proved by running it against a PUBLIC-SHAPED tree — metrics.json plus only the published docs, deliberately no CLAUDE.md and no PROGRESS.md: 5 public docs updated, the two internal ones skipped silently, exit 0, no error output. The four scripts left in that block stay internal because they genuinely are: they act on the public/riina remotes or on the private generator, and an external clone can neither run them nor need them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uu28z8CdRQ1SLzTv8yszth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public branch shipped tooling that pointed at a file it excluded.
sync-metrics.shsat insync-public.sh'sINTERNAL_PATHSunder "internal sync/verification scripts (not needed by external users)". That rationale does not hold for this one: twelve published files reference it.Not just prose
00_SETUP/hooks/pre-commitriinac/tests/metrics_doc_consistency.rsbash scripts/sync-metrics.shand stage the result" — advice a public clone could not followscripts/audit-docs.sh,scripts/godzilla-pipeline.sh.cursorrules,.github/copilot-instructions.md,AGENTS.md,COPILOT.md,llms.txt00_SETUP/MAINTAINER_ONBOARDING.md,DOMAIN_R5_CHECKLIST_v1_0_0.md,scripts/generate-metrics.shHow it surfaced
While back-merging riina's #15, which adds a mirror-local
scripts/mirror-propagate-metrics.sh. That commit exists precisely because the mirror lacks this script, and its message records the consequence:The workaround was the symptom. The exclusion was the cause. (I deliberately did not back-merge that script — proof has the real one, and its author named it distinctly to avoid exactly that collision.)
Safe to publish — verified, not assumed
token|secret|password|api_key|/home/…|/workspaces/|ghp_: zero hitsverify-public.shandpublic-quality-gates.shnever mention itif [ -f ], so the internal-only files it also knows about (CLAUDE.md,PROGRESS.md) are skipped on a tree that lacks themThe last point is the load-bearing one, so I ran it against a public-shaped tree —
metrics.jsonplus only the published docs, deliberately noCLAUDE.mdand noPROGRESS.md:The two internal files were skipped silently, exactly as the guards promise.
What stays internal
The four scripts left in that block genuinely are internal —
sync-public.sh,verify-public.sh,verify-riina-deploy.sh,generate-full-stack.py. They act on the public/riina remotes or on the private generator; an external clone can neither run them nor need them. The comment now records that distinction so the next person doesn't re-add this one by pattern-matching.Generated by Claude Code