Skip to content

fix(nsis): prefix StrReplaceAll with un. for uninstall section #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamvirul merged 3 commits into from
May 3, 2026
Merged

fix(nsis): prefix StrReplaceAll with un. for uninstall section #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04bd60b
fix(nsis): prefix StrReplaceAll with un. for uninstall section
iamvirul May 3, 2026
9a4d10d
Merge branch 'main' into fix/nsis-uninstall-function-prefix
iamvirul May 3, 2026
ce0ff36
chore(changelog): add v1.4.4 release notes
iamvirul May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/windows-installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ Section "Uninstall"
Push "$0"
Push "$INSTDIR;"
Push ""
Call StrReplaceAll
Call un.StrReplaceAll
Pop $0
Push "$0"
Push ";$INSTDIR"
Push ""
Call StrReplaceAll
Call un.StrReplaceAll
Pop $0
WriteRegExpandStr HKLM \
"SYSTEM\CurrentControlSet\Control\Session Manager\Environment" \
Expand Down Expand Up @@ -162,9 +162,10 @@ Function StrContains
Push $R0
FunctionEnd

; ── Helper: StrReplaceAll ────────────────────────────────────────────────────
; ── Helper: un.StrReplaceAll ─────────────────────────────────────────────────
; Stack (top→bottom): [haystack] [find] [replace] → [result]
Function StrReplaceAll
; Must be prefixed un. because it is called from the Uninstall section.
Function un.StrReplaceAll
Exch $2 ; replace
Exch
Exch $1 ; find
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.4.4] - 2026-05-03

### Fixed

- **Windows uninstaller crash — `StrReplaceAll` not found** — NSIS requires functions called from the `Uninstall` section to be defined as `Function un.FunctionName`. `StrReplaceAll` was defined as a plain function, causing `makensis` to abort with "Call must be used with function names starting with 'un.'". Renamed to `un.StrReplaceAll` and updated both call sites. ([#119](https://github.com/iamvirul/deepdiff-db/pull/119))

## [1.4.3] - 2026-05-03

### Added
Expand Down Expand Up @@ -513,6 +519,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- MySQL foreign key check handling

[Unreleased]: https://github.com/iamvirul/deepdiff-db/compare/v1.4.3...HEAD
[1.4.4]: https://github.com/iamvirul/deepdiff-db/compare/v1.4.3...v1.4.4
[1.4.3]: https://github.com/iamvirul/deepdiff-db/compare/v1.4.2...v1.4.3
[1.4.2]: https://github.com/iamvirul/deepdiff-db/compare/v1.4.1...v1.4.2
[1.4.1]: https://github.com/iamvirul/deepdiff-db/compare/v1.4.0...v1.4.1
Expand Down
Loading