Skip to content

Add Laravel 13 support #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamfarhad merged 2 commits into from
May 10, 2026
Merged

Add Laravel 13 support #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3304017
Add Laravel 13 dependency support
iamfarhad May 10, 2026
3026bbd
Test against Laravel 13
iamfarhad May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,19 @@ jobs:
fail-fast: false
matrix:
php: [ 8.1, 8.2, 8.3, 8.4 ]
laravel: [ 10.*, 11.*, 12.* ]
laravel: [ 10.*, 11.*, 12.*, 13.* ]
exclude:
- php: 8.1
laravel: 11.*
- php: 8.1
laravel: 12.*
- php: 8.1
laravel: 13.*
- php: 8.2
laravel: 13.*
include:
- laravel: 13.*
testbench: 11.*
- laravel: 12.*
testbench: 10.*
- laravel: 11.*
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "iamfarhad/validation",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-12 support with both ValidationRule objects & string-based rules.",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-13 support with both ValidationRule objects & string-based rules.",

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Claiming support for Laravel 13 is premature. Laravel 12 is the next major version (expected Q1 2025), and Laravel 13 is not expected until 2026. Including it in the description may be misleading as it cannot be verified yet.

Suggested change
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-13 support with both ValidationRule objects & string-based rules.",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-12 support with both ValidationRule objects & string-based rules.",

"type": "library",
"license": "MIT",
"keywords": [
Expand Down Expand Up @@ -66,12 +66,12 @@
},
"require": {
"php": "^8.1",
"illuminate/support": "^10.0|^11.0|^12.0",
"illuminate/validation": "^10.0|^11.0|^12.0"
"illuminate/support": "^10.0|^11.0|^12.0|^13.0",
"illuminate/validation": "^10.0|^11.0|^12.0|^13.0"
Comment on lines +69 to +70

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding ^13.0 for illuminate dependencies is premature. These versions do not exist yet and cannot be tested. This will cause dependency resolution errors in CI and for users attempting to update, as the author noted that local tests were not run. It is recommended to remove these until the versions are actually available.

Suggested change
"illuminate/support": "^10.0|^11.0|^12.0|^13.0",
"illuminate/validation": "^10.0|^11.0|^12.0|^13.0"
"illuminate/support": "^10.0|^11.0|^12.0",
"illuminate/validation": "^10.0|^11.0|^12.0"

},
"require-dev": {
"phpunit/phpunit": "^10.0|^11.0|^12.0",
"orchestra/testbench": "^8.0|^9.0|^10.0",
"orchestra/testbench": "^8.0|^9.0|^10.0|^11.0",

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding ^11.0 for orchestra/testbench is premature as it corresponds to Laravel 13 support, which is not yet available. This will prevent successful dependency resolution.

Suggested change
"orchestra/testbench": "^8.0|^9.0|^10.0|^11.0",
"orchestra/testbench": "^8.0|^9.0|^10.0",

"mockery/mockery": "^1.0|^2.0",
"phpstan/phpstan": "^1.10 || ^2.0",
"laravel/pint": "^1.0"
Expand Down
Loading