Skip to content

Return nodeName instead of anchorName on Android (replicates upstream #13) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamEtornam merged 1 commit into from
Jul 8, 2026
Merged

Return nodeName instead of anchorName on Android (replicates upstream #13) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions android/src/main/kotlin/com/uhg0/ar_flutter_plugin_2/ArView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ class ArView(
if (node != null) {
var anchorName: String? = null
var currentNode: Node? = node
val nodeName = node.name

@gemini-code-assist gemini-code-assist Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since nodeName is now used instead of anchorName for the tap event, the anchorName and currentNode variables, as well as the entire while loop traversing the parent hierarchy, are now dead code. They should be removed to clean up the codebase and avoid unnecessary parent-traversal and map-lookup operations on every tap.

while (currentNode != null) {
anchorNodesMap.forEach { (name, anchorNode) ->
if (currentNode == anchorNode) {
Expand All @@ -511,7 +512,7 @@ class ArView(
currentNode = currentNode.parent
}
if(handleTaps) {
objectChannel.invokeMethod("onNodeTap", listOf(anchorName))
objectChannel.invokeMethod("onNodeTap", listOf(nodeName))

@gemini-code-assist gemini-code-assist Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since node.name is nullable, nodeName can be null. Passing a list containing null to the Flutter channel will result in tappedNode.toString() being called on null in Dart, which produces the string "null". To prevent this, we should only invoke the method if nodeName is not null.

Suggested change
objectChannel.invokeMethod("onNodeTap", listOf(nodeName))
nodeName?.let { objectChannel.invokeMethod("onNodeTap", listOf(it)) }

}
true
} else {
Expand Down Expand Up @@ -1328,4 +1329,4 @@ class ArView(
}


}
}