Improvement/238 tests for evaluation metrics#242
Merged
Conversation
added 30 commits
February 17, 2026 15:13
…tps://github.com/iai-group/UserSimCRS into improvement/233-create-classes-for-metrics
…tps://github.com/iai-group/UserSimCRS into improvement/233-create-classes-for-metrics
added 7 commits
March 17, 2026 13:32
…mprovement/233-create-classes-for-metrics
|
NoB0
requested changes
Mar 24, 2026
NoB0
reviewed
Mar 28, 2026
NoB0
left a comment
NoB0
left a comment
Collaborator
There was a problem hiding this comment.
General comment on format. In the codebase we typically use types from the typing package. For docstrings the verb is conjugated. I commented on a few of places to change (please check for others that I may have skipped).
Left some comments with clarification questions.
NoB0
reviewed
Apr 13, 2026
dkkdark
commented
Apr 14, 2026
NoB0
reviewed
Apr 21, 2026
NoB0
approved these changes
Apr 21, 2026
NoB0
left a comment
NoB0
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (just one nit to address)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.