Tests - hrrr, lakes - correct path bug input to compare_netcdf_files - #82
Open
jmichellehu wants to merge 1 commit into
Open
jmichellehu wants to merge 1 commit into
jmichellehu wants to merge 1 commit into
Conversation
Call sites input absolute path and overrides output_dir path. Skips gold comparison of hrrr_solar.nc/solar_k.nc. Replace with filename to compare correct source and output files.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test comparison path issues are corrected with no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Corrects NetCDF test comparisons by passing filenames so gold and output paths resolve correctly.
Changes:
- Fixes the Lakes comparison.
- Corrects HRRR solar and
solar_kcomparisons.
| File | Description |
|---|---|
smrf/tests/test_lakes.py |
Uses the correct filename-based comparison. |
smrf/tests/data/hrrr/test_hrrr.py |
Enables valid HRRR output comparisons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call sites input absolute path and overrides output_dir path. Skips gold comparison of hrrr_solar.nc/solar_k.nc. Replace with filename to compare correct source and output files.