Discover SIO when finding and running tests explicitly#224
Merged
Conversation
This is necessary if SIO is not in `LD_LIBRARY_PATH`, for example, when it is built in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
LD_LIBRARY_PATH, for example, when it is built in.ENDRELEASENOTES
I'm not sure if no one does this (I think this used to work fine?) but if I build LCIO with builtin SIO then SIO is not in
LD_LIBRARY_PATH, so I get:It makes sense; the local build of SIO is not in
LD_LIBRARY_PATH, and even if RPATHS are set and correct (I checked) this is Catch2's discovery (DL_PATHSI'm not sure exactly what it does). The change inLD_LIBRARY_PATHis probably (didn't check) needed when rpaths are not enabled and the SIO library is not inLD_LIBRARY_PATH.