fix: extend support for r/w feature flags - #4220
Open
IgorEisberg wants to merge 1 commit into
Open
Conversation
IgorEisberg
enabled auto-merge (squash)
August 29, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for decoding R/W feature flags from
RES_TABLE_FLAGGEDandRES_TABLE_FLAG_LISTin ARSC, as well asResXMLTreeFlagExtblocks in AXML.New
ResXmlPullEventHandlertakes care of recordingandroid:featureFlagsin all binary XML files, soResXmlUtils.pullManifestFeatureFlags(manifest)is obsolete.Everything was written with performance in mind and avoiding costly calls before checking if they're needed.
Extra:
ResStringPoolreusable, this cleans unnecessary null checks.equalsimplementations' class checks.hashCodeimplementations (Objects.hashis convenient, but implicitly allocates an array each call).YamlReaderandYamlWriterto take aCollectionover aListfor flexibility.closes: #4217