Skip to content

fix: extend support for r/w feature flags - #4220

Open
IgorEisberg wants to merge 1 commit into
mainfrom
featureflags
Open

fix: extend support for r/w feature flags#4220
IgorEisberg wants to merge 1 commit into
mainfrom
featureflags

Conversation

@IgorEisberg

@IgorEisberg IgorEisberg commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Adds support for decoding R/W feature flags from RES_TABLE_FLAGGED and RES_TABLE_FLAG_LIST in ARSC, as well as ResXMLTreeFlagExt blocks in AXML.
New ResXmlPullEventHandler takes care of recording android:featureFlags in all binary XML files, so ResXmlUtils.pullManifestFeatureFlags(manifest) is obsolete.
Everything was written with performance in mind and avoiding costly calls before checking if they're needed.

Extra:

  • Make ResStringPool reusable, this cleans unnecessary null checks.
  • Stricter equals implementations' class checks.
  • Optimized hashCode implementations (Objects.hash is convenient, but implicitly allocates an array each call).
  • Tweak YamlReader and YamlWriter to take a Collection over a List for flexibility.

closes: #4217

@IgorEisberg
IgorEisberg enabled auto-merge (squash) August 29, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant