Skip to content

fix(cli): reject builds without web client #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HeroOfOdyssey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): reject builds without web client #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/server/scripts/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
ServerCliDevelopmentIconTargetMissingError,
ServerCliPublishIconSourceMissingError,
ServerCliPublishIconTargetMissingError,
ServerCliWebBuildMissingError,
} from "./cliErrors.ts";

interface PackageJson {
Expand Down Expand Up @@ -170,7 +171,7 @@ const buildCmd = Command.make(
yield* applyDevelopmentIconOverrides(repoRoot, serverDir);
yield* Effect.log("[cli] Bundled web app into dist/client");
} else {
yield* Effect.logWarning("[cli] Web dist not found — skipping client bundle.");
return yield* new ServerCliWebBuildMissingError({ webDistPath: webDist });
}
}),
).pipe(Command.withDescription("Build the server package (tsdown + bundle web client)."));
Expand Down
11 changes: 11 additions & 0 deletions apps/server/scripts/cliErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ export class ServerCliDevelopmentIconTargetMissingError extends Schema.TaggedErr
}
}

export class ServerCliWebBuildMissingError extends Schema.TaggedErrorClass<ServerCliWebBuildMissingError>()(
"ServerCliWebBuildMissingError",
{
webDistPath: Schema.String,
},
) {
override get message(): string {
return `Missing web client build output: ${this.webDistPath}. Build @backplane/web before the CLI.`;
}
}

export class ServerCliBuildAssetMissingError extends Schema.TaggedErrorClass<ServerCliBuildAssetMissingError>()(
"ServerCliBuildAssetMissingError",
{
Expand Down
Loading