[Aikido] Fix 9 security issues in lodash, @actions/github, @octokit/core and 1 more - #24
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
4 Open source vulnerabilities detected - critical severity
Aikido detected 4 vulnerabilities across 1 package, it includes 1 critical and 3 high vulnerabilities.
Details
Remediation:
undici— 4 CVEs (critical) — fixed in 6.24.0
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade lodash, @actions/github, @octokit/core, and uuid to fix critical RCE vulnerability in template compilation via options.imports injection and HIGH severity buffer overflow in UUID generation. This update includes breaking changes that require manual migration.
@octokit packages - Node.js version requirement (v7.0.0+, v8.0.0+)
Where your code is affected:
action.yml:7specifiesusing: node24, and all octokit usage insrc/gh.js:9, 22, 35Impact: The upgraded @octokit packages require Node.js >= 18. While the action currently runs on Node.js 24 (which satisfies this requirement), the package-lock.json shows the currently installed versions have no such requirement. This creates a hard dependency on Node.js 18+ that wasn't there before.
Remediation: Verify that all environments where this action runs support Node.js 18 or higher, and update documentation to reflect this minimum requirement.
@octokit/request - Removal of custom request options (v8.0.0)
Where your code is affected:
src/gh.js:9, 22, 35wheregithub.getOctokit()is calledImpact: The upgrade removes the ability to pass custom request options except for
method,headers,body,signal, anddata. While the current code doesn't explicitly pass custom options, the@actions/githubpackage internally configures a proxy agent viaUtils.getProxyAgent()(visible indist/index.js). This proxy agent configuration may no longer work with v8.0.0.Remediation: Review the
@actions/githubpackage compatibility with the new @octokit/request version to ensure proxy support still functions correctly, or migrate to using fetch dispatchers as documented in the new version.All breaking changes by upgrading lodash from version 4.17.21 to 4.18.1 (CHANGELOG)
_.unset/_.omitnow blockconstructorandprototypeas non-terminal path keys unconditionally. Calls that previously returnedtrueand deleted the property now returnfalseand leave the target untouched._.templatenow throws"Invalid imports option passed into _.template"whenimportskeys contain forbidden identifier characters, which were previously allowed.✅ 9 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
linkheaders, allowing attackers to cause denial of service through specially crafted requests.