Fail closed on deletion-only line attribution - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Git encodes a deletion-only zero-context hunk such as
@@ -2 +1,0 @@with a zero-length new-side range anchored at current line 1. ProofDiff'sDiffHunkrepresentation currently stores that asnewRange: { start: 1, end: 1 }. Direct interval matching therefore treated the unchanged current line 1 as changed, which could falsely report both a parser-observed call and a current symbol as part of the change.The fix does not guess which anchor is real code. It validates that the sum of reconstructed current-side hunk spans exactly matches Git's numstat
additions; if not, current changed-symbol/call attribution is withheld and the limitation is reported. This preserves existing coverage's fail-closed philosophy without changing the public hunk schema.Verification
@@ -2 +1,0 @@deletion-only shape with an unchanged call on the anchor linechangedSymbolsandchangedCallsremain emptynpm testpassednpm run clean && npm run buildpassedgit diff --checkpassed