Preserve LCOV source-path whitespace - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SF:source-path records before repository-path resolutiondistand document the evidence-boundary fixWhy
parseLcov()usedrecord.slice(3).trim(). That normalization changes LCOV path identity: for example,SF:src/value.js(NBSP) was interpreted assrc/value.js. If the artifact then reported hits for changed lines, ProofDiff could attach coverage evidence to a different repository path than the one named by the artifact.Coverage artifacts are explicitly user-supplied and not independently attested, but ProofDiff still must not strengthen them by rewriting path identity. The parser now preserves the
SF:payload exactly and lets normal repository containment checks decide whether it matches a changed file.Verification
npm testpassed after the changenpm run clean && npm run buildpassedsrc/coverage.ts,tests/coverage.test.ts,CHANGELOG.md, and regenerateddist/coverage.*; temporary updater files were removed