Exercise adversarial JS runner rejection cases - #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js:test:testbefore asking the targeted-runner parser to reject itWhy
The previous aggregate regression put most adversarial commands under names such as
test:substitution,test:chain, andtest:dotenv.discoverChecks()intentionally recognizes only the bounded namestest,test:unit,test:ci,test:all, andcheck:test, so those entries were never passed torecognizedRunnerScript()at all. The test still passed because the one recognizedtestentry (jest --coverage) was opaque, creating a false sense of coverage over the other rejection boundaries.This change gives each adversarial command its own fixture under the recognized
testname and explicitly asserts discovery reached that check before asserting targeted runner inference stays empty. It also locks in the post-CR/LF parser boundary for non-ASCII whitespace.Verification
npm testpassed with the corrected regression matrixtests/js-runners.test.ts; temporary updater files were removed