Do not infer Python runners from stub-only tests - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pytest file before layout-based Python framework discovery can infer pytest orunittest.pyifiles available to static Python analysis and test-like relationship discoverydistWhy
detectPythonTests()accepted both.pyand.pyitest-shaped filenames even though Python target qualification already rejects.pyi. That meant a repository containing only test-shaped type stubs could cause--run-checksto launchpython -m pytestorpython -m unittestdespite having no executable Python test file. This crossed ProofDiff's own separation between broad test-like relationship discovery and runnable-target identity.The fix narrows only framework discovery. Stub files remain valid source/static relationship inputs; they simply cannot create an executable runner by themselves.
Verification
npm testpassed after the changenpm run buildregenerateddist.pyistubs and static relationship preservation