Add async variant of some functions where it is useful#48
Open
debbiedub wants to merge 5 commits into
Open
Conversation
When creating the tests, I didn't manage to understand how to create all of them so some tests are skipped.
The reason for this is to allow to set a limit of the amount of concurrent operations by having a task group that limits the amount of "started" coroutines. No such task group implementation exists in the asyncio library but there is one in test_anode.py for the purpose of testing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new async primitives the old waiting or callback interface is a little cumbersome. Here is an attempt to allow handling multiple FCP calls in parallel using the async await and asyncio.
Sofar this is only tested with the provided tests. I plan to use it in future applications.