chore(deps-dev): bump mox from 1.2.0 to 1.3.0 in /elixir-orchestration - #258
Conversation
Bumps [mox](https://github.com/dashbitco/mox) from 1.2.0 to 1.3.0. - [Changelog](https://github.com/dashbitco/mox/blob/main/CHANGELOG.md) - [Commits](dashbitco/mox@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: mox dependency-version: 1.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the mix.lock file but fails to include the corresponding changes in mix.exs, creating a configuration mismatch. Additionally, the upgrade to Mox 1.3.0 introduces a requirement for Elixir 1.15 or higher, which has not been confirmed for the project environment. These gaps in the acceptance criteria should be addressed to ensure the update is correctly implemented and compatible.
About this PR
- Verify that the project and CI environment are running Elixir 1.15 or higher. Mox 1.3.0 relies on features not present in earlier versions, and failing to meet this requirement will cause test failures.
- The
mix.exsfile is missing from the pull request. Both the dependency definition inmix.exsand the resolution inmix.lockmust be updated together to ensure configuration consistency.
Test suggestions
- Verify that existing tests using
Moxmocks and stubs continue to pass after the upgrade. - Verify that process-based allowances work correctly with the new
Process.info(pid, :parent)discovery method.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that existing tests using `Mox` mocks and stubs continue to pass after the upgrade.
2. Verify that process-based allowances work correctly with the new `Process.info(pid, :parent)` discovery method.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
A newer version of mox exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps mox from 1.2.0 to 1.3.0.
Changelog
Sourced from mox's changelog.
Commits
0aa8871Release v1.3.011c5e93Better "no expectation found" error (#174)f8234d0Fix undefined protocol error (#172)53f7908Require Elixir 1.15+ and update CI (#173)758623eAdd warning to stub/3 (#169)89e22d7Clarify Mox.allow/3 usage with deferred functions (#166)20e3ac9Use Process.info(pid, :parent) when available (#164)9daacd7Refactor one (1) private function (#163)3d8199eUpdate CI test matrix to Elixir 1.18eff4af7Support Elixir 17/Erlang OTP 27 in CI (#161)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)