-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/token permissions id 20260911 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
52d6144
102f5b3
46b13f9
08d48c4
ac2a6b1
3ba8988
ca9fe50
d996938
efd257f
37b7ab6
bf9b899
c68eb7e
b330020
43ae649
e01dda8
b6adc8b
9134886
42f73af
3f99fe1
7a06251
ed1daf9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,7 +21,7 @@ on: | |||||
| types: [completed] | ||||||
|
|
||||||
| permissions: | ||||||
| contents: write | ||||||
| contents: read | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- workflow permissions and job header ---'
sed -n '1,55p' .github/workflows/rhodibot.yml
printf '%s\n' '--- branch, push, and pull-request path ---'
sed -n '155,210p' .github/workflows/rhodibot.yml
printf '%s\n' '--- permission and credential references ---'
rg -n -C 3 'permissions:|contents:|pull-requests:|GITHUB_TOKEN|git push|gh pr create|actions/checkout' .github/workflows/rhodibot.ymlRepository: hyperpolymath/vcl-ut Length of output: 4521 🤖 get_repo_knowledge executed:
Length of output: 14237 Restore When Proposed fix permissions:
- contents: read
+ contents: write
pull-requests: write📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| pull-requests: write | ||||||
|
|
||||||
| jobs: | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,7 +53,7 @@ jobs: | |
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/satellite-crates-gate.yml | sed -n '1,120p'
rg -n 'persist-credentials|actions/checkout|GITHUB_TOKEN|contents:' .github/workflowsRepository: hyperpolymath/vcl-ut Length of output: 9065 🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
Sensitive Data Exposure Reachability: External Disable persisted checkout credentials. This workflow runs repository-controlled 🧰 Tools🪛 zizmor (1.29.0)[warning] 55-60: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) 🤖 Prompt for AI Agents |
||
|
|
||
| # rustup is preinstalled on ubuntu-latest; no third-party action | ||
| # (avoids the action-pinning / deprecated-cache hazards). Mirrors | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,16 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| name: Scorecards supply-chain security | ||
| # SPDX-License-Identifier: PMPL-1.0-or-later | ||
| name: OSSF Scorecard | ||
|
|
||
| on: | ||
| branch_protection_rule: | ||
| push: | ||
| branches: [main, master] | ||
| schedule: | ||
| - cron: '23 4 * * 1' | ||
| - cron: '0 4 * * *' | ||
| workflow_dispatch: | ||
|
|
||
| permissions: read-all | ||
| permissions: | ||
| contents: read | ||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- scorecard workflow ---'
cat -n .github/workflows/scorecard.yml
printf '%s\n' '--- workflow references ---'
rg -n --glob '*.yml' --glob '*.yaml' 'scorecard|publish_results|security-events|id-token|workflow_call' .github
printf '%s\n' '--- reusable workflow (public source) ---'
curl -fsSL https://raw.githubusercontent.com/hyperpolymath/standards/main/.github/workflows/scorecard-reusable.yml | sed -n '1,220p'Repository: hyperpolymath/vcl-ut Length of output: 8013 🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- scorecard workflow ---'
cat -n .github/workflows/scorecard.yml
printf '%s\n' '--- workflow references ---'
rg -n --glob '*.yml' --glob '*.yaml' 'scorecard|publish_results|security-events|id-token|workflow_call' .github
printf '%s\n' '--- reusable workflow (pinned commit) ---'
curl -fsSL https://raw.githubusercontent.com/hyperpolymath/standards/5a93d9d57cc04de4002d6d0ecd336fc7a8698910/.github/workflows/scorecard-reusable.yml | sed -n '1,240p'Repository: hyperpolymath/vcl-ut Length of output: 2192 🏁 Script executed: #!/bin/bash
set -eu
cat -n .github/workflows/scorecard.yml
printf '\n--- local workflow references ---\n'
rg -n --glob '*.yml' --glob '*.yaml' 'scorecard|publish_results|security-events|id-token|workflow_call' .github || true
printf '\n--- referenced reusable workflow ---\n'
curl -fsSL https://raw.githubusercontent.com/hyperpolymath/standards/5a93d9d57cc04de4002d6d0ecd336fc7a8698910/.github/workflows/scorecard-reusable.yml | sed -n '1,240p'Repository: hyperpolymath/vcl-ut Length of output: 2168 Security Misconfiguration Reachability: Internal Grant the Scorecard job's required permissions. The reusable workflow requires Proposed fix jobs:
scorecard:
+ permissions:
+ contents: read
+ security-events: write
+ id-token: write
uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@5a93d9d57cc04de4002d6d0ecd336fc7a8698910🤖 Prompt for AI Agents |
||
|
|
||
| jobs: | ||
| analysis: | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@81dbf2dd854b1444fd6236fa2352474383b2c2b9 | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| id-token: write | ||
| secrets: inherit | ||
| scorecard: | ||
| uses: hyperpolymath/standards/.github/workflows/scorecard-reusable.yml@5a93d9d57cc04de4002d6d0ecd336fc7a8698910 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Restore
contents: writefor the auto-merge job. The reachable Dependabot path runsgh pr merge --auto --squashwithGITHUB_TOKEN.pull-requests: writepermits approval, but GitHub requirescontents: writeto enable auto-merge.contents: readtherefore prevents eligible security updates from being auto-merged.🤖 Prompt for AI Agents