chore(lean4): bump toolchain v4.12.0 -> v4.34.1 (P0-3) - #213
Merged
Merged
Conversation
- lean-toolchain: leanprover/lean4:v4.34.1 - PathTraversal: List.dropLast_append_of_ne_nil no longer takes the list as an explicit argument; pass only the non-empty proof. This is the only v4.34 regression. - SymlinkOperations: trailing `/-- Summary -/` doc comment had no declaration to attach to (parse error on v4.12.0 too); make it a plain block comment. No proof changed. - rust-cli.yml lean4 job: elan --default-toolchain v4.34.1. - lakefile header: last verified v4.34.1 (2026-10-02), and list which libs build. FileContentOperations, RMOOperations, CopyMoveOperations and PermissionOperations fail on v4.12.0 as well (measured from a clean `git archive HEAD` build) and are not touched here. Theorem count 111 -> 111, sorry 0 -> 0, no axioms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Hypatia Security ScanFindings: 120 issues detected
View findings[
{
"reason": "Job `triage` in label-triage.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": ".github/workflows/label-triage.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "triage"
},
{
"reason": "Job `sync` in labels.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": ".github/workflows/labels.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "sync"
},
{
"line": 38,
"reason": "job in .github/workflows/labels.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/labels.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 44,
"reason": "job in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/push-email-notify.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 46,
"reason": "job in .github/workflows/cflite_batch.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/cflite_batch.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 45,
"reason": "job in .github/workflows/cflite_pr.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/cflite_pr.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 20,
"reason": "job in .github/workflows/instant-sync.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/instant-sync.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 83,
"reason": "job in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/hypatia-scan.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 52,
"reason": "job in .github/workflows/label-triage.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/label-triage.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
},
{
"line": 88,
"reason": "workflow .github/workflows/compilation_tests.yml:88 step `Run ignored tests (stress)` swallows non-zero exit via `continue-on-error: true` — failures will be masked",
"type": "RE005",
"file": ".github/workflows/compilation_tests.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ULTRAPLAN P0-3 — Lean toolchain v4.12.0 → v4.34.1 (D9: latest stable on 2026-10-02).
Build matrix (every lib built explicitly with
lake build <lib>; baseline from a cleangit archiveof 4401867)Changes
lean-toolchain→leanprover/lean4:v4.34.1;rust-cli.yml--default-toolchainto match (the only build-relevant v4.12 pin;lean-verification.ymlreadslean-toolchain).PathTraversal.lean:102—List.dropLast_append_of_ne_nillost its explicit list argument. The only real v4.34 regression; the theorem statement is unchanged.SymlinkOperations.lean:61— trailing/-- Summary -/doc comment with no declaration was a parse error on v4.12.0 too, so its 3 theorems never checked; now a plain comment, and they check.Theorems (grep) 111 → 111 ·
sorry0 → 0 · noaxiom· noset_optionescapes · default targets unchanged.⚠ Status correction this PR surfaces (not fixed here)
46 of the 111 theorems live in four libs that have never built: CopyMoveOperations (11), RMOOperations (14), FileContentOperations (13), PermissionOperations (8). Under the five-status taxonomy they are DESIGNED, not PROVEN. CI never noticed because it builds only the default target,
Extractionandmodel_oracle. CopyMove opens namespaces that do not exist (Valence.Filesystem,Valence.FileOps), and RMO cites a lemma that does not exist (deleteFile_preserves_other_paths). Repairing them is real proof work → Phase 1 (V1) / P1-0 claims ledger. Same forCLAUDE.md's "101 theorems" (grep: 111).Logs:
llm-coding-configs/claude/20261002-vsh-lean434/on the dev machine (v412-*,before-*,after-*).Stacked on top: P0-4 (oracle no-skip-as-pass).
🤖 Generated with Claude Code
https://claude.ai/code/session_01VxcAoyMQe7CjQwCKL18Mm4