docs: add Signed commits section to CONTRIBUTING - #63
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (26)
|
| Layer / File(s) | Summary |
|---|---|
Commit signing and pull request rules CONTRIBUTING.adoc |
The guidance requires signed commits, specifies signing methods for people and automated contributors, and requires squash merges. It also states that unsigned commits on pull request branches block merging and that affected branches must be recreated with signed commits. Rebase merging is disabled. |
Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to a28e7
The contribution guidance is consistent with the documented signed-commit checks. Some external settings and automation details could not be confirmed, but the review found no demonstrated contributor failure.
Security Architecture Review
Security architecture risk: 🔵 Low · up to a28e7
The change adds contributor signing guidance without changing executable controls or granting permissions. No introduced security weakness was established, but the stated enforcement settings and automated signing guarantees are not fully verified.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
- inferred — The directly affected security surface is contributor guidance for commits and PRs reaching this repository’s default branch. The changed text does not itself expand tenant, service, credential, or data-store authority.
Trust Boundaries and Controls
- observed — The document assigns signing responsibility to contributors for interactive commits and to GitHub for API-created automation commits. It attributes unsigned-commit rejection to a ruleset; the text is not evidence that the full hosted configuration or every credential’s signing behavior matches those assertions.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the purpose and main changes, but it omits the required RSR Quality Checklist and a dedicated Testing section. It also does not explicitly address the applicable documentation… | Add the RSR Quality Checklist with applicable items checked. Add a Testing section that states the validation performed, or explains why no tests apply to this documentation-only change. Confirm that documentation was updated. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the documentation change to CONTRIBUTING and matches the main change. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Description check
Explanation
The description explains the purpose and main changes, but it omits the required RSR Quality Checklist and a dedicated Testing section. It also does not explicitly address the applicable documentation checklist item.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks each commit’s mark
And signs each hop before the dark
Squash the trail to make it neat
Signed commits keep the branch complete
Then off I bound on tidy feet
Comment @coderabbitai help to get the list of available commands.
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f