chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #73
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#73hyperpolymath wants to merge 1 commit into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
|
|
||
| # REQUIRES INITIALISATION | ||
|
|
||
| **This repository is not finished being set up.** 1 substitution token(s) across 1 file(s) still have no value. |
There was a problem hiding this comment.
⚠️ Bug: REQUIRES_INITIALISATION undercounts unfilled tokens (misses {{project}})
REQUIRES_INITIALISATION.md and the new 0-AI-MANIFEST.a2ml priority action both state only "1 substitution token(s) across 1 file(s)" remain (just {{LICENSE}} in ABI-FFI-README.md). In reality the lowercase {{project}} token is still unfilled in ffi/zig/build.zig (5 occurrences), ffi/zig/test/integration_test.zig (~20 occurrences, including live extern fn declarations and call sites that will not compile), and ABI-FFI-README.md (~24 occurrences). {{project}} is mechanically derivable (this PR already filled the uppercase {{PROJECT}} to CANDY_CRASH), so per the PR's own rules it should have been filled — and if left, it must be surfaced. The accounting is therefore both wrong and misleading: an agent trusting these files will believe setup is nearly complete. Fix by substituting {{project}} with the derived lowercase name (e.g. candy_crash), or at minimum list {{project}} and all three files in REQUIRES_INITIALISATION.md and correct the counts.
Was this helpful? React with 👍 / 👎
| (github-is-source-of-truth #t))) | ||
|
|
||
| <!-- BEGIN requires-initialisation --> | ||
|
|
||
| ## PRIORITY ACTION — this repository is not fully initialised | ||
|
|
||
| 1 substitution token(s) still have no value. **Read | ||
| `REQUIRES_INITIALISATION.md` in the repository root before doing anything | ||
| else here** — it lists every outstanding token, what it means, and which | ||
| files it belongs in. | ||
|
|
||
| Do not fabricate values for them, and do not delete the sections that | ||
| contain them to quiet a gate. They are unfilled because they need a | ||
| decision, not because they were overlooked. Resolve what you legitimately | ||
| can, leave the rest, and delete `REQUIRES_INITIALISATION.md` only when |
There was a problem hiding this comment.
💡 Quality: Markdown/HTML appended after closed s-expression in a2ml manifest
0-AI-MANIFEST.a2ml is an s-expression manifest (the top-level form closes with ))) on line 16). The new block on lines 18-33 appends HTML comments and Markdown (<!-- ... -->, ## PRIORITY ACTION) outside any parenthesized form. Unlike the leading # comment lines, this content is neither valid s-expression syntax nor a recognized comment, so a strict a2ml/sexpr parser consuming this "AI Agent Entry Point" may error or silently drop the notice. Consider embedding the priority action inside a proper form (e.g. a (requires-initialisation ...) node) or as #-prefixed comment lines consistent with the file's existing comment style.
Was this helpful? React with 👍 / 👎
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review
|
| Compact |
|
Important
Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
|
Closing in favour of a reworked substituter — hyperpolymath/standards#590. This sweep filled Those are the scripts whose job is to perform template substitution. Filling the left-hand side of their own Four further shapes came out of the same cause:
The rule plain replacement cannot express: a placeholder is sometimes a value to fill and sometimes the subject being discussed. standards#590 encodes that distinction and is tested against this exact corruption (9/9, the first three cases reproducing it). Nothing here is lost — the placeholder filling will be redone with that tool. Closing rather than fixing forward because repairing 289 branches individually would repeat the mistake at the same scale. |
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code