Fix AttributeError in health_reporter from dict iteration and missing Connection attributes#1
Draft
Copilot wants to merge 3 commits into
Draft
Fix AttributeError in health_reporter from dict iteration and missing Connection attributes#1Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…nection and fixing dict iteration Co-authored-by: WesP10 <97987799+WesP10@users.noreply.github.com>
…ion fix Co-authored-by: WesP10 <97987799+WesP10@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error collecting service metrics due to incorrect data type
Fix AttributeError in health_reporter from dict iteration and missing Connection attributes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The health reporter crashed with
AttributeError: 'str' object has no attribute 'port_id'when collecting service metrics because it iterated over dict keys instead of values, and theConnectiondataclass was missingbytes_read/bytes_writtenattributes.Changes
Added byte counters to
Connectiondataclass (serial_manager.py)bytes_readandbytes_writtenfields (default 0)_read_continuously(),read_from_port(), andwrite_to_port()Fixed dict iteration
for conn in active_connections→for conn in active_connections.values()inhealth_reporter.pyandapi/connections.pyget_active_connections()returnsDict[str, Connection]; iterating directly loops over keys (strings), not Connection objectsAdded tests (
test_connection_bytes_tracking.py)Example
Before:
After:
Original prompt
Created from VS Code.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.