enable declaring custom topics for ffi interface publish and ff publish api create #1734
Open
ka1ii wants to merge 3 commits into
Open
enable declaring custom topics for ffi interface publish and ff publish api create #1734ka1ii wants to merge 3 commits into
ka1ii wants to merge 3 commits into
Conversation
Signed-off-by: Kaijun Zhang <kaijun1543111@gmail.com>
EnriqueL8
reviewed
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Thanks @ka1ii - would love to understand if all the comments from @awrichar have been addressed kaleido-io#140
Along with that suggest:
- Updating the docs
- Handling empty topics passed in better
| APISubscriptionStartSequenceID = ffm("api.startsequenceid", "The sequence ID in the raw event stream to start indexing through events from. Leave blank to start indexing from the most recent events") | ||
| APISubscriptionEndSequenceID = ffm("api.endsequenceid", "The sequence ID in the raw event stream to stop indexing through events at. Leave blank to start indexing from the most recent events") | ||
|
|
||
| APICustomTopicsQueryParam = ffm("api.customTopicsQueryParam", "Custom topics for ordering definition broadcast messages") |
Contributor
There was a problem hiding this comment.
Wouldn't call it query param, as it's past in at POST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
allow clients to declare custom topics for ffi interface publish and ff publish api create
Fixes #1725
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.