fix(ci): use check-api target in dashandapi_post pipeline#779
Open
khanak0509 wants to merge 2 commits into
Open
fix(ci): use check-api target in dashandapi_post pipeline#779khanak0509 wants to merge 2 commits into
khanak0509 wants to merge 2 commits into
Conversation
Signed-off-by: khanak0509 <kkhanak512@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the dashandapi_post CI pipeline by updating it to use the correct Make target for running API tests, aligning the pipeline with the active root Makefile (issue #778).
Changes:
- Replaced
make test-apiwithmake check-apiinci/dashandapi_post.ymlso the pipeline calls an existing Make target.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YoungHypo
reviewed
May 22, 2026
Member
YoungHypo
left a comment
YoungHypo
left a comment
There was a problem hiding this comment.
Thanks — the fix is correct. But this file is part of the old Azure DevOps pipeline, which looks like dead config now. Holding this until I align with the other maintainers.
Author
|
Sure, thanks for the context, @YoungHypo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
Updated the CI command in ci/dashandapi_post.yml to use the correct Make target.
Before
Pipeline step called make test-api (target not present in active Makefile).
After
Pipeline step now calls make check-api (target exists in active Makefile).
The active root Makefile defines check-api and does not define test-api.