add value completion. - #67
Open
srivastava-diya wants to merge 5 commits into
Open
Conversation
srivastava-diya
commented
Aug 6, 2026
srivastava-diya
commented
Aug 6, 2026
srivastava-diya
commented
Aug 6, 2026
srivastava-diya
force-pushed
the
value-completion-simple
branch
from
August 17, 2026 20:14
b37520c to
3d7462f
Compare
srivastava-diya
marked this pull request as ready for review
August 17, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggests values for a property based on what its schema allows.
Completion.tsis now an orchestrator over two providersPropertyCompletionfor keys,ValueCompletionfor values and MatchingSchemaCollector is split intoAnnotationEvaluationPluginandCompletionEvaluationPlugin.What it suggests
Keywords handled
typeenumconstnotallOfanyOfoneOfif/then/else$refpropertiesadditionalPropertiesrequiredThere are two paths, and they exist for different reasons:
resolveValueInfohelper reads a property's own subschema statically, because when we're typing "color": there's no value yet for the validator to go into. That path has to interpret applicator keywords itself, which is why$refandthen/elseappear there explicitly.Out of scope for this PR.
Testing
45 value-completion tests (1 skipped) , all asserting the complete response. Value tests are grouped by keyword with comment markers.