Repository navigation
fix: stop -w and -o changing bytes they did not fix - #20
Merged
Merged
Conversation
-w rebuilt the file from its lines, turning CRLF into LF, adding a final newline and turning an empty file into one newline while reporting 0 fixes. Each line now keeps its own terminator. -o now copies the input's permission bits, so a fixed script stays executable. A file that cannot be read is reported on stderr and the other files are still scanned, exiting 1. The run only aborts when nothing could be read. Text output printed the line number twice (2:2:1). It is now 2:1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes in the fix path and text output.
Done when -w on CRLF, no-trailing-newline and empty input reports 0 fixes and changes no bytes.
Closes #7
Closes #8
Closes #9