Skip to content

Treat an unrecognised label visibility as visible #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdbg merged 1 commit into from
Sep 20, 2026
Merged

Treat an unrecognised label visibility as visible #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions inc/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,24 +112,21 @@ static function ( array $matches ) use ( $icon, $position ): string {
* front end is the raw comment JSON, never merged against registered
* defaults — see the file docblock in `inc/attributes.php`. So an explicit
* `'hidden'` or an explicit `'mobile'` always wins, and a `'visible'` only
* counts once the legacy flag is confirmed clear; otherwise the legacy flag
* decides, exactly as it did before this attribute existed.
* counts once the legacy flag is confirmed clear. Otherwise the legacy flag
* decides, exactly as it did before this attribute existed. A value outside
* the enum is treated as absent, so it never hides a label by itself.
*
* @param array $attributes The block's attributes.
* @return string One of 'visible', 'mobile', 'hidden'.
*/
function label_visibility( array $attributes ): string {
$visibility = $attributes['hmLabelVisibility'] ?? 'visible';

if ( 'hidden' === $visibility ) {
return 'hidden';
if ( in_array( $visibility, [ 'hidden', 'mobile' ], true ) ) {
return $visibility;
}

if ( 'visible' === $visibility && empty( $attributes['hmHideLabelOnMobile'] ) ) {
return 'visible';
}

return 'mobile';
return empty( $attributes['hmHideLabelOnMobile'] ) ? 'visible' : 'mobile';
}

/**
Expand Down
10 changes: 3 additions & 7 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,11 @@ const NO_ICON = {
function resolveLabelVisibility( attributes ) {
const { hmLabelVisibility, hmHideLabelOnMobile } = attributes;

if ( 'hidden' === hmLabelVisibility ) {
return 'hidden';
if ( [ 'hidden', 'mobile' ].includes( hmLabelVisibility ) ) {
return hmLabelVisibility;
}

if ( 'visible' === hmLabelVisibility && ! hmHideLabelOnMobile ) {
return 'visible';
}

return 'mobile';
return hmHideLabelOnMobile ? 'mobile' : 'visible';
}

/**
Expand Down
Loading