Stop one bad filter taking down every page with a button - #5
Merged
Merged
Conversation
render_block_core/button runs for every button, and render() returns the content untouched when there is no icon. With strict types on, a null from an earlier filter on the hook made that return a TypeError, so one misbehaving filter elsewhere took down every page with a button on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render()runs for everycore/button, icon or not, and hands the content straight back when there is no icon. With strict types on, anullfrom an earlier filter on the hook made that return aTypeError.