Fix malformed BPE merges panicking during build#2219
Open
0xzr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Malformed BPE merge definitions could panic in
BpeBuilder::buildbefore returning the existingMergeTokenOutOfVocabularyerror:This validates the prefix slice and merged length before writing to the buffer. A result longer than every vocabulary token is necessarily out of vocabulary, so it can return the existing error without allocating a larger buffer or changing valid-model behavior.
Regression tests cover both panic paths.
Fixes #2198
Tests
make lintHF='uvx --from huggingface_hub hf' make test