Fix XSS in EncodingVisualizer HTML attributes#2216
Open
varneeth01 wants to merge 1 commit into
Open
Conversation
Author
|
Escape all user-controlled values inserted into HTML data-* attributes in EncodingVisualizer. Previously, visible text was escaped but attribute values were not, which could allow malformed HTML or script injection if token or annotation values contained special characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an HTML attribute injection vulnerability in
bindings/python/py_src/tokenizers/tools/visualizer.py.While visible text was already escaped by the earlier fix in #1937, several
data-*attribute values were still constructed directly from untrusted tokenor annotation text. A malicious value containing quotes could terminate the
attribute and inject additional HTML attributes or elements when the generated
HTML was rendered.
This change:
html.escape(..., quote=True)data-stokenattributeFixes
Fixes #2210
Testing