Clarify byte-level pretokenizer behavior#2195
Open
michaelalbada wants to merge 2 commits into
Open
Conversation
Author
|
Hi @Pierrci, would you mind taking a look at this PR? |
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
ty for the writeup! we are kinda gonna remove it soon, as performance wise this really dose not make a lot of sense to have!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the
ByteLevelpre-tokenizer docs around raw byte input.ByteLeveloperates on Unicode strings and maps their UTF-8 bytes to visible byte-level characters. Passing arbitrary bytes decoded as Latin-1 can therefore re-encode bytes above 127 as UTF-8 and produce unexpected tokens.This PR:
ByteLeveldocsDesigned to address [[https://github.com//issues/1877]]