Repository navigation
fix(bind): forget the older notes before the setups run - #248
Merged
Merged
Conversation
`funes bind local` forgot the note an older funes kept beside an agent only once that agent's setup succeeded. A setup that failed left its note, and the next bare `funes add` or `funes update` migrated it and bound the host back to that memory, undoing the local choice. The host's record replaces the notes as it is written, whatever the setups do. Every bind does it, not only `bind local`: nothing reads a note while the host is bound, so one rule covers both and `follow` no longer forgets per agent. Fixes #244. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dacorvo
commented
Oct 15, 2026
dacorvo
left a comment
dacorvo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed 8b97ef7f, including the shared add and update migration paths. No actionable findings.
Clearing the legacy notes before running setups prevents a failed setup from leaving a note that a later bare add or update could adopt. The cleanup also includes the agent excluded from setup during add. The regression test covers a failing setup during bind local.
No tests run, as requested. CI validation is pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
funes bindnow forgets every note an older funes kept beside the agents, whatever their setups do. Before, a failing setup kept its note, and the next barefunes addorfunes updatebound the host back to that memory, undoingfunes bind local.Found by Copilot in the review of #241. Fixes #244.
🤖 Generated with Claude Code