Repository navigation
fix(bind): give a host with no local memory the bound memory's model - #247
Merged
Merged
Conversation
`funes bind <memory>` compared embedding models only when a local memory existed. On a host with none, nothing created it with the bound memory's model, so the next `funes index` (a hook's included) created an English one, and every push to a multilingual memory failed the model check. bind_host now takes the memory's model when the host has no local memory, as `funes add` does, and stops when it can't read that memory: guessing could pin the local memory to another model. The offline error no longer names `funes add`, since bind and update reach it too. Fixes #243. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dacorvo
commented
Oct 15, 2026
dacorvo
left a comment
dacorvo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed 3d83375a, including the shared add and legacy migration paths and the first push after binding. No actionable findings.
The new path creates the local memory with the bound memory's model before recording the binding or running setups. Existing local memories still go through the model mismatch check. The regression test checks the model stored in the newly created local dataset.
No tests run, as requested. CI validation is pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
funes bind <memory>on a host with no local memory now creates it with the bound memory's model, asfunes adddoes. Before, the next index (a hook's included) created an English memory, and every push to a multilingual memory failed the model check.Like
add,bindstops when it can't read that model. On an empty host bound to a populated memory it now also tries the first push, which just says there is nothing to publish yet.Found by Copilot in the review of #241. Fixes #243.
🤖 Generated with Claude Code