Skip to content

refactor lumina2 pipeline tests to the new mixin structure - #14629

Merged
sayakpaul merged 4 commits into
huggingface:mainfrom
akshan-main:lumina2-tests-migration
Aug 28, 2026
Merged

refactor lumina2 pipeline tests to the new mixin structure#14629
sayakpaul merged 4 commits into
huggingface:mainfrom
akshan-main:lumina2-tests-migration

Conversation

@akshan-main

Copy link
Copy Markdown
Contributor

What does this PR do?

Refactors the Lumina2 pipeline tests to the new mixin structure from #14113: a Lumina2PipelineTesterConfig plus TestLumina2Pipeline(PipelineTesterMixin) and TestLumina2PipelineMemory(MemoryTesterMixin), with dummy inputs switched to output_type="pt" and a fresh CPU slice in test_inference.

One note: output_shape is (3, 4, 4), since the dummy one-block VAE decodes the 4x4 latents at scale 1 (the old file never asserted an output shape, so the small size went unnoticed). This unblocks moving tests/lora/test_lora_layers_lumina2.py to the pipeline-level LoRA mixins, which I will follow up with. Follows #14628.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Discussed on Slack with @sayakpaul
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@sayakpaul

@github-actions github-actions Bot added tests size/M PR with diff < 200 LOC labels Aug 27, 2026

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshan-main

Copy link
Copy Markdown
Contributor Author

done, folded it in here instead of the follow-up. 43 passing locally on cpu

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul
sayakpaul merged commit a8c33fe into huggingface:main Aug 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR with diff < 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants