Share fsspec filesystem across threads when resolving data files#8286
Open
Ijtihed wants to merge 1 commit into
Open
Share fsspec filesystem across threads when resolving data files#8286Ijtihed wants to merge 1 commit into
Ijtihed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8149.
_get_origin_metadataresolves each data file in aThreadPoolExecutorand every worker builds its own filesystem viaurl_to_fssince fsspec caches filesystem instances per thread. For cloud backends likes3://orgcs://this re-resolves credentials and opens a new connection pool in each thread.This builds the filesystem once per protocol in the main thread and passes it to the workers which just strip the protocol off the path instead of rebuilding it.
hf://paths and chained::urls keep the same behavior as before