Fix Mypy typing invariance by updating List to Sequence in dataset loading functions (#5354)#8282
Open
Paramveersingh-S wants to merge 1 commit into
Open
Fix Mypy typing invariance by updating List to Sequence in dataset loading functions (#5354)#8282Paramveersingh-S wants to merge 1 commit into
Paramveersingh-S wants to merge 1 commit into
Conversation
…s to fix invariance typing issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #5354. The standard
typing.List(or built-inlist) is invariant in Python, meaning static analyzers like Mypy will complain if a user tries to pass a tuple or another valid sequence into the dataset loading parameters (e.g.data_files). By refactoring these type hints fromlisttotyping.Sequence(which is covariant) acrossfrom_csv,from_json,from_parquet, andfrom_text, we satisfy type checkers for read-only sequence data paths.This change ensures cleaner integration for downstream users who use tuples or custom sequence subclasses when loading datasets.
Checklist