Skip to content

fix(dataset): accept pathlib.Path in save_to_disk and load_from_disk #8271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirtiRamchandani wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix(dataset): accept pathlib.Path in save_to_disk and load_from_disk #8271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1847,6 +1847,7 @@ def save_to_disk(
# if we have only a few large samples, we should only create as many shards as samples
num_shards = min(len(self.data), num_shards)

dataset_path = str(dataset_path)
fs: fsspec.AbstractFileSystem
fs, _ = url_to_fs(dataset_path, **(storage_options or {}))

Expand Down Expand Up @@ -2018,6 +2019,7 @@ def load_from_disk(
>>> ds = load_from_disk("path/to/dataset/directory")
```
"""
dataset_path = str(dataset_path)
fs: fsspec.AbstractFileSystem
fs, dataset_path = url_to_fs(dataset_path, **(storage_options or {}))

Expand Down
7 changes: 7 additions & 0 deletions tests/test_arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,13 @@ def test_dummy_dataset_serialize(self, in_memory):
self.assertEqual(dset[0]["filename"], "my_name-train_0")
self.assertEqual(dset["filename"][0], "my_name-train_0")

with self._create_dummy_dataset(in_memory, tmp_dir).select(range(10)) as dset:
dataset_path = Path(tmp_dir) / "my_dataset_pathlib"
dset.save_to_disk(dataset_path)

with Dataset.load_from_disk(dataset_path) as dset:
self.assertEqual(len(dset), 10)

with self._create_dummy_dataset(in_memory, tmp_dir).select(
range(10), indices_cache_file_name=os.path.join(tmp_dir, "ind.arrow")
) as dset:
Expand Down