Add the supports of missing types in conversion between arrow and dtype types#8258
Open
Alex-PLACET wants to merge 2 commits into
Open
Add the supports of missing types in conversion between arrow and dtype types#8258Alex-PLACET wants to merge 2 commits into
Alex-PLACET wants to merge 2 commits into
Conversation
…nversion - Map fixed_size_binary to "fixed_size_binary[n]" and list to "list[<type>]" in _arrow_to_datasets_dtype - Parse fixed_size_binary[...] in string_to_arrow and return pa.binary(byte_width) - Add test coverage for fixed_size_binary roundtrip
Author
|
@lhoestq Hi Quentin. A gentle ping to run the workflows |
Member
|
Hi! Can you only include the change for fixed_size_binary ? For the other types it requires discussing them in an issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue is a crash in _arrow_to_datasets_dtype because the miss of support of fixed_size_binary:
In this pull request I add the support for all the missing types