Implement #58#60
Merged
Merged
Conversation
- Add Save Session Settings toggle under Misc - Add @AppStorage properties to SettingsHandler for saved display, zoom, constant FPS, and mute - Init @State vars from saved values in ParsecView.init - Persist to SettingsHandler on toggle/change, restore in post() - Fix viewDidAppear to respect zoomEnabled instead of hardcoding false
Display selection is host-dependent upon connection and seems to require the primary monitor?
|
Any eta on when this will be merged? |
Contributor
Author
|
not sure but there are quite a few PRs that are waiting on @hugeBlack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Save Session Settings under Misc (enabled by default)
-Persist zoom, constant FPS, and mute via
@AppStorage-Restore values on init + post()
-Respect
zoomEnabledinviewDidAppear(no more hardcoded false)Closes #58