fix(harbor): recognise multi-step tasks in the converter#509
Open
Ulusha wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0198416. Configure here.
Ulusha
force-pushed
the
ulusha/fix-harbor-multi-step-detection
branch
from
July 23, 2026 13:08
0198416 to
f6ef295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

_is_harbor_taskrequires a rootinstruction.md, so valid multi-step tasks aren't recognised — their instructions live understeps/<name>/, declared by a[[steps]]array intask.toml.load()then raisesno Harbor tasks foundor drops every task at parse.Reproducible on Harbor's own
examples/tasks/hello-multi-step-simple:though Harbor's own tooling builds and runs it fine.
Fix: recognise a task by a parseable
task.tomlplus an instruction in either form — rootinstruction.md(single-step) or a[[steps]]array (multi-step)._is_harbor_taskand_parse_taskshare the check.Behaviour note:
_parse_tasknow rejects an unparseabletask.toml(previously tolerated with an empty config), since detection must read it.Tested: 3 single-step + 2 multi-step tasks accepted; non-Harbor folder,
task.tomlwithout instruction/steps, and brokentask.tomlrejected.Note
Low Risk
Scoped to Harbor task discovery/parsing in the integration layer, with new tests; behavior change is limited to which task directory layouts are accepted.
Overview
Harbor load/detect no longer treats a root
instruction.mdas mandatory. Tasks are valid whentask.tomlparses and either that file exists (single-step) or the config defines a[[steps]]array (multi-step, instructions understeps/<name>/)._read_task_config,_task_has_instruction, and updated_is_harbor_task/_parse_taskshare that rule.task.tomlalone (no root instruction and no steps) is excluded. Brokentask.tomlstill loads only if a rootinstruction.mdis present (empty config); multi-step dirs without parseable config are dropped because steps cannot be detected otherwise.Tests add
make_multi_step_taskand cover detect/load for multi-step tasks, mixed datasets, and baretask.tomlrejection.Reviewed by Cursor Bugbot for commit f6ef295. Bugbot is set up for automated code reviews on this repo. Configure here.