fix(agents): allow create_agent + HostedRuntime for training configs (HUD-2100)#503
Open
ChinmayK0607 wants to merge 2 commits into
Open
fix(agents): allow create_agent + HostedRuntime for training configs (HUD-2100)#503ChinmayK0607 wants to merge 2 commits into
ChinmayK0607 wants to merge 2 commits into
Conversation
Tag gateway clients from build_gateway_client so hosted_spec can strip them and rebuild remotely. Preserve system_prompt and completion_kwargs (return_token_ids, Tinker/Qwen). Reject true BYOK clients with HUDRuntime guidance. Document TrainingClient runtime placement (HUD-2100). Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 700c774. Configure here.
Mark gateway clients with an instance attribute only. The id() fallback could reuse after GC and mis-classify a BYOK client as serializable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_gateway_clientsohosted_speccan strip them and let the hosted runner rebuild from the model name.create_agent(...)+HostedRuntimenow preservessystem_promptandcompletion_kwargs(return_token_ids, Tinker/Qwen kwargs).model_clientstill fails early, with guidance to useHUDRuntime/LocalRuntime.HUDRuntimefor training;HostedRuntimeis supported forcreate_agentgateway agents.Fixes HUD-2100.
Test plan
test_hosted_spec_strips_create_agent_gateway_client— create_agent client + system_prompt + return_token_ids / chat_template_kwargs round-triptest_hosted_spec_rejects_custom_model_client— still rejects BYOK, mentions HUDRuntimetest_hosted.py,test_base.py) — 28 passedMade with Cursor