Skip to content

fix help page finder list of paths - #1931

Open
mdlama wants to merge 1 commit into
hubzero:2.4-mainfrom
qubeshub:fix-core-bug
Open

mdlama wants to merge 1 commit into
hubzero:2.4-mainfrom
qubeshub:fix-core-bug

Conversation

@mdlama

@mdlama mdlama commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

The first four paths are incorrect. $tmpl already includes template directory. Only need four paths: two for the app template overrides of component and plugin, and two for the core component and plugin.

Before you submit this pull request, please make sure:

  • Make sure there are links in the PR to the source JIRA card(s) and hubzero ticket(s)
  • Include a brief summary of the issue in your own words
  • Include a brief summary of the fix/changed code
  • Include a brief summary of your testing. What did you specifically do to investigate that this change has the correct results?
  • Indicate if the change needs to be hotfixed to any production hubs before a normal core rollout
  • Double check someone is assigned to review the ticket

Thanks!

Test before fix and after fix

Output below is from echo '<pre>' . print_r($paths, true) . '</pre>'; die;. Indices 0-3 in Before fix are removed. When there is a template override, in After fix, indices 0-1 map to the app override (e.g. on QUBES, /var/www/html/public/app/templates/bmc).

Before fix:

Array
(
    [0] => /var/www/html/public/app/templates//var/www/html/public/core/templates/system/html/plg_collections_index/help/en-GB/index.phtml
    [1] => /var/www/html/public/app/templates//var/www/html/public/core/templates/system/html/com_collections/help/en-GB/index.phtml
    [2] => /var/www/html/public/core/templates//var/www/html/public/core/templates/system/html/plg_collections_index/help/en-GB/index.phtml
    [3] => /var/www/html/public/core/templates//var/www/html/public/core/templates/system/html/com_collections/help/en-GB/index.phtml
    [4] => /var/www/html/public/core/templates/system/html/plg_collections_index/help/en-GB/index.phtml
    [5] => /var/www/html/public/core/templates/system/html/com_collections/help/en-GB/index.phtml
    [6] => /var/www/html/public/core/components/com_collections/site/help/en-GB/index.phtml
    [7] => /var/www/html/public/core/plugins/collections/index/help/en-GB/index.phtml
)

After fix:

Array
(
    [0] => /var/www/html/public/core/templates/system/html/plg_collections_index/help/en-GB/index.phtml
    [1] => /var/www/html/public/core/templates/system/html/com_collections/help/en-GB/index.phtml
    [2] => /var/www/html/public/core/components/com_collections/site/help/en-GB/index.phtml
    [3] => /var/www/html/public/core/plugins/collections/index/help/en-GB/index.phtml
)

I don't think this needs to be hotfixed.

This is the only difference found between QUBES app com_help override and core.

The first four paths are incorrect. $tmpl already includes template
directory. Only need four paths: two for the app template overrides of
component and plugin, and two for the core component and plugin.
@mdlama
mdlama requested a review from nkissebe as a code owner September 27, 2026 13:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant