Fix Keychain persistence in production builds - #84
Merged
Conversation
Direct Developer ID releases can lack the application identifier entitlement, so Data Protection Keychain writes return errSecMissingEntitlement. Fall back to the encrypted login Keychain and preserve legacy items unless protected migration actually succeeds.
Bump the marketing version to 0.4.4 and build number to 10 for the production Keychain persistence hotfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the production credential-saving failure reported in #83.
The signing and provisioning configuration is intentionally unchanged; adding a restricted Keychain entitlement is outside this hotfix.
Validation
git diff --check origin/main...HEADReview State
Source and Credit
Fixes #83. This is an independent implementation based on reproducing the reporter's production failure and probing both macOS Keychain implementations.