Skip to content

Fix Keychain persistence in production builds - #84

Merged
hubab1 merged 2 commits into
mainfrom
codex/fix-production-keychain
Aug 16, 2026
Merged

Fix Keychain persistence in production builds#84
hubab1 merged 2 commits into
mainfrom
codex/fix-production-keychain

Conversation

@hubab1

@hubab1 hubab1 commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fall back to the encrypted macOS login Keychain only when the Data Protection Keychain reports a missing entitlement.
  • Preserve an existing login-Keychain item unless migration to the protected store actually succeeds.
  • Add regression coverage for Release behavior and safe migration.
  • Prepare OpenASO 0.4.4 (build 10).

This fixes the production credential-saving failure reported in #83.

The signing and provisioning configuration is intentionally unchanged; adding a restricted Keychain entitlement is outside this hotfix.

Validation

  • Relevant focused tests — 40 tests passed.
  • Full test suite — 686 tests in 60 suites passed.
  • Launch smoke check — a Developer ID-signed Release build saved credentials, relaunched without credential environment variables, reloaded the Keychain item, and verified successfully again.
  • git diff --check origin/main...HEAD

Review State

  • Ready for review

Source and Credit

Fixes #83. This is an independent implementation based on reproducing the reporter's production failure and probing both macOS Keychain implementations.

hubab1 added 2 commits August 16, 2026 09:42
Direct Developer ID releases can lack the application identifier entitlement, so Data Protection Keychain writes return errSecMissingEntitlement. Fall back to the encrypted login Keychain and preserve legacy items unless protected migration actually succeeds.
Bump the marketing version to 0.4.4 and build number to 10 for the production Keychain persistence hotfix.
@hubab1
hubab1 merged commit ecad696 into main Aug 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Store Connect connection issue

1 participant