Skip to content

Support App Store URLs when adding apps - #79

Draft
hubab1 wants to merge 1 commit into
mainfrom
codex/add-app-store-url
Draft

Support App Store URLs when adding apps#79
hubab1 wants to merge 1 commit into
mainfrom
codex/add-app-store-url

Conversation

@hubab1

@hubab1 hubab1 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept either a numeric App Store ID or an HTTPS apps.apple.com URL in Add App
  • extract and normalize the ID before using the existing direct lookup
  • update the field label, action, help text, and validation message
  • add parser coverage for the reported Mac App Store URL and invalid or untrusted inputs

Why

Mac apps may not appear in the name-search catalogue, making direct ID lookup the normal way to add them. Requiring users to manually extract the numeric ID from an App Store URL adds unnecessary friction.

Root cause

The Add App flow passed the field directly to Int64, so full App Store URLs were always rejected even though the ID was present in the URL path.

Validation

  • xcodebuild test -project OpenASO.xcodeproj -scheme OpenASO -destination 'platform=macOS,arch=arm64' -derivedDataPath Build CODE_SIGNING_ALLOWED=NO
  • full test suite passed
  • exact mt=12 Mac App Store URL from the report is covered by a unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant