Skip to content

feat: implement archival mode to prevent event deletion #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oyetanishq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: implement archival mode to prevent event deletion #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions golpe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,6 @@ config:
- name: events__maxTagValSize
desc: "Maximum size for tag values, in bytes"
default: 1024
- name: events__archivalMode
desc: "Archival mode: no deleting of events"
default: false
19 changes: 12 additions & 7 deletions src/events.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,11 @@ void writeEvents(lmdb::txn &txn, NegentropyFilterCache &neFilterCache, std::vect
if (isEventABeforeEventB(packed, otherPacked)) {
ev.status = EventWriteStatus::Replaced;
} else {
if (logDeletions) LI << "Deleting event (d-tag). id=" << to_hex(otherPacked.id());
levIdsToDelete.push_back(otherEv.primaryKeyId);
if (!cfg().events__archivalMode) {
if (logDeletions) LI << "Deleting event (d-tag). id=" << to_hex(otherPacked.id());
levIdsToDelete.push_back(otherEv.primaryKeyId);
}
}

return false;
}, true);

Expand Down Expand Up @@ -333,8 +334,10 @@ void writeEvents(lmdb::txn &txn, NegentropyFilterCache &neFilterCache, std::vect
if (tagName == 'e') {
auto otherEv = lookupEventById(txn, tagVal);
if (otherEv && PackedEventView(otherEv->buf).pubkey() == packed.pubkey()) {
if (logDeletions) LI << "Deleting event (kind 5, e-tag). id=" << to_hex(tagVal);
levIdsToDelete.push_back(otherEv->primaryKeyId);
if (!cfg().events__archivalMode) {
if (logDeletions) LI << "Deleting event (kind 5, e-tag). id=" << to_hex(tagVal);
levIdsToDelete.push_back(otherEv->primaryKeyId);
}
}
} else if (tagName == 'a') {
try { // parsing a-tag can fail
Expand All @@ -350,8 +353,10 @@ void writeEvents(lmdb::txn &txn, NegentropyFilterCache &neFilterCache, std::vect
auto otherPacked = PackedEventView(otherEv.buf);

if (otherPacked.created_at() <= packed.created_at()) {
if (logDeletions) LI << "Deleting replaceable event (kind 5, a-tag). id=" << to_hex(otherPacked.id());
levIdsToDelete.push_back(otherEv.primaryKeyId);
if (!cfg().events__archivalMode) {
if (logDeletions) LI << "Deleting replaceable event (kind 5, a-tag). id=" << to_hex(otherPacked.id());
levIdsToDelete.push_back(otherEv.primaryKeyId);
}
}

return false;
Expand Down
3 changes: 3 additions & 0 deletions strfry.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ events {

# Maximum size for tag values, in bytes
maxTagValSize = 1024

# Archival mode: no deleting of events
archivalMode = false
}

relay {
Expand Down