Harden series artwork authorization scope from route - #133
Draft
hotzenplotz5 wants to merge 24 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/api/backends/<backend>/settings/series-artworkroute;set -e/errexit in user shell blocks, wait only for change-relevant CI jobs, and omit installation/restart commands when installable content did not change;Lokaler Bau, Test und Installationcommand block;Root cause
SecurityHttpGateoriginally readbackendIdfrom the JSON body for this route. The handler later rejected a route/body mismatch, so cross-backend mutation was blocked, but the pre-dispatch authorization decision and accountability evidence could be scoped to the body rather than the authoritative route.Validation
The focused
make test-security-series-artwork-route-scopetarget is part oftest-securityand therefore the repository's full GitHub Actions test graph.The latest commits after the previously green implementation head modify documentation and the handoff guardrail only. Their required validation is the documentation/guardrail path; daemon, packaging and frontend jobs are not gating for those documentation-only changes.
Previous fully validated implementation head:
c76ba58577abab59a382ebc7b1b2b40d9b3fe2adVDR-Suite CI #7012, run ID
30890406190, completed successfully with all five jobs green:fast-regression-test, including the focused security test, handoff guardrail and daemon build;packaging-regression-test, including install staging;frontend-regression-test;docs-check;make-test-audit.Local commands supplied to the user are not claimed as locally executed by GitHub Actions. Installation or service restart is not required for documentation-only handoff changes.