Skip to content

test(cli): add env-gated scenario integration tests#139

Merged
zfarrell merged 1 commit into
mainfrom
test/cli-scenario-integration-tests
Jun 5, 2026
Merged

test(cli): add env-gated scenario integration tests#139
zfarrell merged 1 commit into
mainfrom
test/cli-scenario-integration-tests

Conversation

@zfarrell
Copy link
Copy Markdown
Contributor

@zfarrell zfarrell commented Jun 5, 2026

Closes #129. Adds binary-driven integration tests mirroring the shared scenario manifest, env-gated on HOTDATA_SDK_TEST_* so cargo test passes offline. Covers workspaces_list, connections_read, query_async_polling, results_arrow, auth_missing_token_401, auth_unknown_workspace; the CLI opts out of the rest via the manifest. Depends on hotdata-dev/www.hotdata.dev#213 — merge that first or the scenario-parity job will fail.

@sentry
Copy link
Copy Markdown

sentry Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

steps:
- name: Generate GitHub App token
id: app-token
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: the integration job is documented as fork-safe (skips cleanly when secrets are absent), but scenario-parity will hard-fail on PRs from forks — create-github-app-token errors out when HOTDATA_AUTOMATION_APP_ID / HOTDATA_AUTOMATION_PRIVATE_KEY aren't injected. If fork PRs are in scope, consider gating this job on github.event.pull_request.head.repo.fork == false (or a secret presence check) for consistency. If forks are out of scope for this internal tool, ignore. (not blocking)

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-documented env-gated integration tests. JSON field assertions match src/, the skip-macro gating is sound, and the tests run-and-skip safely under the existing CI test job. One non-blocking super nit left inline re: parity job on fork PRs.

@zfarrell zfarrell merged commit 9cd8bc6 into main Jun 5, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(cli): add env-gated scenario/integration tests mirroring SDK manifest

1 participant